Edit alert flyout by YulNaumenko · Pull Request #58964 · elastic/kibana

YulNaumenko · 2020-02-29T01:29:35Z

Summary

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-02-29T01:29:37Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…alert_flyout # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

gmmorris

I haven't been able to get the UI to work for me yet, so not approving, but I can't see anything worrying, so happy to approve once I get to test the UI. :)

x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api.ts

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.tsx

x-pack/plugins/triggers_actions_ui/public/common/constants/aggregation_types.ts

gmmorris · 2020-03-03T05:26:16Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts

+      // TODO: uncomment variables test when server API will be ready
+      // await testSubjects.click('slackAddVariableButton');
+      // const variableMenuButton = await testSubjects.find('variableMenuButton-0');
+      // await variableMenuButton.click();


Has this been forgotten or is it still in progress? :)

In progress, we have an issue for this #58529

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts

…alert_flyout # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.tsx # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts

…alert_flyout # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…alert_flyout # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx

gmmorris

Talked with @YulNaumenko about a couple of points and a UI bug - all seems to already be known and documented in other issues, so approving this. 👍

pmuellr

code LGTM

I loaded up the PR, was able to edit an alert \o/

A few issues; have to modify the interval number to save (but also on create), and an alert saved with an interval 1s comes up in the edit form as 1 minute instead. We can open these as separate issues. Let's ship this thing!

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx

kibanamachine · 2020-03-04T20:56:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c2c10ac

History

💚 Build #30835 succeeded 5a7f9ee
💔 Build #30614 failed 9293714
💔 Build #30588 failed 129af25
💔 Build #30493 failed 410a763

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Implemented edit alert functionality * Added unit tests * Added functional test for edit alert * Fixed failed tests * Fixed edit api * Fixed due to comments * Fixed functional test * Fixed tests * Fixed add alert * Small type fix * Fixed jest test * Fixed type check * Fixed bugs with interval and throttle + index threshold expression

* Edit alert flyout (#58964) * Implemented edit alert functionality * Added unit tests * Added functional test for edit alert * Fixed failed tests * Fixed edit api * Fixed due to comments * Fixed functional test * Fixed tests * Fixed add alert * Small type fix * Fixed jest test * Fixed type check * Fixed bugs with interval and throttle + index threshold expression * Removed before all from alert jest tests * Fixed type check

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (254 commits) Convert discover_page to ts, remove redundunt methods (elastic#59312) [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873) Delete legacy search endpoint (elastic#59341) [Uptime] Improve duration chart (elastic#58404) [Snapshot & Restore] NP migration (elastic#59109) [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017) Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)" Change remote_clusters ID to remoteClusters (elastic#59246) Makes alerting and actions optional properties for interface RequestH… (elastic#59264) Clean up date histogram agg type. (elastic#58805) [ML] Management: fix license unsubscribe (elastic#59365) Remove documentation for server.cors settings (elastic#59096) Edit alert flyout (elastic#58964) [SIEM] Fix rule delete/duplicate actions (elastic#59306) move mouse to close obstructing tooltip (elastic#59214) Reset page after deleting (elastic#59310) Make sure phrases input filter triggers autosuggestons (elastic#59299) Add loading count source for http requests (elastic#59245) Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)" Expose metrics service to public API (elastic#59294) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - #58395 - #58964 - #60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - elastic#58395 - elastic#58964 - elastic#60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - #58395 - #58964 - #60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>

Implemented edit alert functionality

36f728b

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Feb 29, 2020

YulNaumenko requested a review from a team as a code owner February 29, 2020 01:29

YulNaumenko self-assigned this Feb 29, 2020

Added unit tests

4ce956b

patrykkopycinski mentioned this pull request Mar 2, 2020

[SIEM] Add rule notifications #59004

Merged

7 tasks

YulNaumenko added 4 commits March 2, 2020 08:45

Added functional test for edit alert

82f29e6

Fixed failed tests

971db47

Fixed edit api

490f772

gmmorris suggested changes Mar 3, 2020

View reviewed changes

YulNaumenko added 2 commits March 3, 2020 07:43

Merge remote-tracking branch 'upstream/master' into alerting_ui_edit_…

76a2884

…alert_flyout # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.tsx # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts

Fixed due to comments

47cbad5

YulNaumenko requested a review from gmmorris March 3, 2020 17:40

YulNaumenko added 7 commits March 3, 2020 10:52

Fixed functional test

f7f99e5

Fixed tests

2b2dff2

Fixed add alert

ed4f836

Small type fix

129af25

Fixed jest test

6fddf14

Merge remote-tracking branch 'upstream/master' into alerting_ui_edit_…

9293714

…alert_flyout # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx

gmmorris approved these changes Mar 4, 2020

View reviewed changes

pmuellr approved these changes Mar 4, 2020

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx Outdated Show resolved Hide resolved

YulNaumenko added 2 commits March 4, 2020 09:50

Fixed type check

5a7f9ee

Fixed bugs with interval and throttle + index threshold expression

c2c10ac

YulNaumenko merged commit daf6226 into elastic:master Mar 4, 2020

YulNaumenko mentioned this pull request Mar 4, 2020

[7.x] Edit alert flyout (#58964) #59373

Merged

mikecote added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit alert flyout#58964

Edit alert flyout#58964
YulNaumenko merged 17 commits intoelastic:masterfrom
YulNaumenko:alerting_ui_edit_alert_flyout

YulNaumenko commented Feb 29, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Feb 29, 2020

Uh oh!

gmmorris left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmmorris Mar 3, 2020

Uh oh!

YulNaumenko Mar 3, 2020

Uh oh!

Uh oh!

gmmorris left a comment

Uh oh!

pmuellr left a comment

Uh oh!

Uh oh!

kibanamachine commented Mar 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

YulNaumenko commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Feb 29, 2020

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmmorris Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

YulNaumenko Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Mar 4, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

YulNaumenko commented Feb 29, 2020 •

edited

Loading